Skip to content

Open "java.net" for reflection #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

Open "java.net" for reflection #2058

merged 1 commit into from
Mar 28, 2023

Conversation

Vassiliy-Kudryashov
Copy link
Member

Description

Some of generated tests required reflection access to "java.net" package (Java 17+)

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@Vassiliy-Kudryashov Vassiliy-Kudryashov added comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug labels Mar 28, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov requested review from Markoutte and Domonion and removed request for Markoutte March 28, 2023 12:01
Domonion
Domonion approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@Domonion Domonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you very much for you contribution!!!

@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) March 28, 2023 12:09
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 0c25714 into main Mar 28, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/open_java_net_package_for_reflection branch March 28, 2023 13:13
@alisevych alisevych added this to the 2023.3 Release milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Domonion Domonion Domonion approved these changes

Assignees
No one assigned
Labels
comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug
Projects
None yet
Milestone
2023.3 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@Vassiliy-Kudryashov @Domonion @alisevych